Skip to content

CRAFT-2074-eslint-v9-migration #3216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
valoriecarli wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

CRAFT-2074-eslint-v9-migration #3216

valoriecarli wants to merge 4 commits into from

Conversation

@valoriecarli
Copy link
Contributor

@valoriecarli valoriecarli commented Jan 30, 2026 •
edited
Loading

experimental branch under test to be linked in with commercetools/merchant-center-application-kit#3931

Background
The appkit eslint9 PR introduces:

  • New package- @commercetools-frontend/eslint-config-mc-app-flat for ESLint 9 + flat config support
  • ESLint 9 compatibility- Upgraded to TypeScript ESLint v8, eslint-plugin-jest v28, and other ESLint 9-compatible
    plugins
  • Flat config format - Modern array-based configuration replacing legacy .eslintrc format
  • Deprecation of @commercetools-frontend/eslint-config-mc-app (ESLint 8 only)

This PR consumes the ESLint 9 migration changes from ☝🏻 and makes the following changes to accommodate it:

  1. Migrated to ESLint 9 Flat Config
  • Removed legacy .eslintrc.js and .eslintignore files
  • Added eslint.config.js (flat config format)
  • Extends @commercetools-frontend/eslint-config-mc-app-flat
  • Custom rules for ui-kit specific needs (testing-library overrides)
  1. Dependency updates:
  • @commercetools-frontend/eslint-config-mc-app-flat - currently linked to file:./vendor/...-hash.tgz--> NEEDS TO BE DELETED AND ADDED TO GITIGNORE. linked to test CI runs.
  • @typescript-eslint/eslint-plugin
  • @typescript-eslint/parser
  • eslint
  • eslint-formatter-pretty
  1. Misc
  • Fixed linting issues caught by stricter rules
  • Updated imports in generators

Once complete, we can close out:

@vercel
Copy link

vercel bot commented Jan 30, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ui-kit Ready Ready Preview, Comment Feb 4, 2026 8:45pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 433dd42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@valoriecarli valoriecarli self-assigned this Jan 30, 2026
@valoriecarli valoriecarli mentioned this pull request Jan 30, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@valoriecarli valoriecarli

Labels

🛑 Status: blocked 🚧 Status: WIP Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@valoriecarli